Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect default infra-image in the message of podman pod create --help #13037

Closed
noracenofun opened this issue Jan 27, 2022 · 1 comment
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@noracenofun
Copy link

noracenofun commented Jan 27, 2022

The new default image in 4.0.0-rc2 is a locally built one based on a local pause binary, build result e.g. "localhost/podman-pause:4.0.0-rc2-1642795764" and no longer the image "k8s.gcr.io/pause:3.5" (DefaultInfraImage = "k8s.gcr.io/pause:3.5"), but the command podman pod create --help does not yet support this feature for the output of the default infra-image.

If the user does not specify an image, the builtin image is now used.

The default hardcoded image defined via DefaultInfraImage is no longer pulled.


But the command podman pod create --help does not yet support this feature for the output of the default infra-image.

no default configuration of infra_image in any containers.conf

$ podman pod create --help | grep infra-image
      --infra-image string            The image of the infra container to associate with the pod (default "k8s.gcr.io/pause:3.5")

expected output for example: ... (default "localhost/podman-pause:4.0.0-rc2-1642795764") or (default "builtin") or nothing
received output: ... (default "k8s.gcr.io/pause:3.5")


default configuration of infra_image set in local containers.conf

$ grep infra_image .config/containers/containers.conf
infra_image = "registry.access.redhat.com/ubi8/pause"

$ podman pod create --help | grep infra-image
      --infra-image string            The image of the infra container to associate with the pod (default "registry.access.redhat.com/ubi8/pause")

output as expected: ... (default "registry.access.redhat.com/ubi8/pause")


The output message should be corrected.


Originally posted by @noracenofun in #12771 (comment)

@mheon mheon added the kind/bug Categorizes issue or PR as related to a bug. label Jan 27, 2022
@Luap99
Copy link
Member

Luap99 commented Feb 4, 2022

Fixed in #13064

@Luap99 Luap99 closed this as completed Feb 4, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

3 participants