Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correction output of podman pod create --help #13043

Closed
wants to merge 1 commit into from
Closed

correction output of podman pod create --help #13043

wants to merge 1 commit into from

Conversation

noracenofun
Copy link

@noracenofun noracenofun commented Jan 27, 2022

because of issue #13037

should fixed by #13064

this PR is history

before correction

$ podman pod create --help | grep infra-image
      --infra-image string            The image of the infra container to associate with the pod (default "k8s.gcr.io/pause:3.5")

should be like this after correction

$ podman pod create --help | grep infra-image
      --infra-image string            Image to use for infra container, rather than builtin

if infra-image set via containers.conf

$ podman pod create --help | grep infra-image
      --infra-image string            Image to use for infra container, rather than builtin (default "registry.access.redhat.com/ubi8/pause")

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: noracenofun
To complete the pull request process, please assign mtrmac after the PR has been reviewed.
You can assign the PR to them by writing /assign @mtrmac in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

cmd/podman/pods/create.go Outdated Show resolved Hide resolved
cmd/podman/pods/create.go Show resolved Hide resolved
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat @rhatdan PTAL

Reminder: Podman builds the local image even if containers.conf sets it to the k8s pause image. The consensus to do that was driven by the fact that we'd otherwise keep on pulling the k8s image on existing machines after an update.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up: CI will reject the commit as is. Please add [NO NEW TESTS NEEDED] to the body of the commit.

default infra-image in the message of podman pod create --help corrected

[NO NEW TESTS NEEDED]

Signed-off-by: noracenofun <62801810+noracenofun@users.noreply.github.com>
@rhatdan
Copy link
Member

rhatdan commented Jan 28, 2022

I believe this is wrong, and we should stop using the DefaultInfraImage, it should just be "" to indicate use builtin image.

containers/common#910 Should change default.

We should work on #13064

@noracenofun noracenofun deleted the fix-issue-#13037 branch January 29, 2022 09:59
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants