-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot remove container [...]: given PIDs did not die within timeout #17142
Comments
I'm a little reluctant here, because it will basically result in a frozen Podman for most of a minute if the process is legitimately not going to die (zombie process or similar) - and I am somehow doubting that the CI VMs are slow enough that it takes more than 5 seconds for a SIGKILL to be processed (but then again, maybe I'm wrong). |
There may very well be (another) bug? Let's keep an eye open and wait for more reports from @edsantiago. CI is sick at the moment, so there may be other things interfering (although unlikely). |
|
I'll tackle this one tomorrow. I had a look today already but then moved on to the bud flake |
it smells so badly like a race |
#17165 ... same race as before but an improvement of the previous PR (details in the PR description) |
Commit 067442b improved stopping/killing a container by detecting whether the cleanup process has already fired and changed the state of the container. Further improve on that by returning early instead of trying to wait for the PID to finish. At that point we know that the container has exited but the previous PID may have been recycled already by the kernel. [NO NEW TESTS NEEDED] - the absence of the two flaking tests recorded in containers#17142 will tell. Fixes: containers#17142 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
New flake, failed twice in one PR:
The text was updated successfully, but these errors were encountered: