Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rawhide: podman diff of buildah container: error creating overlay mount #9507

Closed
edsantiago opened this issue Feb 24, 2021 · 5 comments · Fixed by containers/storage#840
Closed

rawhide: podman diff of buildah container: error creating overlay mount #9507

edsantiago opened this issue Feb 24, 2021 · 5 comments · Fixed by containers/storage#840
Assignees
@giuseppe
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Podman fedora gating tests are failing in one of the diff tests.

Simplest reproducer:

# buildah from --name foo quay.io/libpod/alpine:latest
...
# buildah run foo sh -c 'touch /newfile'
# podman diff foo
ERRO[0000] error unmounting /var/lib/containers/storage/overlay/3027f967eb6b2ddf9ceebce0100d00d5109e47895d0fe837a97396287d5b314e/merged: invalid argument
Error: error creating overlay mount to /var/lib/containers/storage/overlay/3027f967eb6b2ddf9ceebce0100d00d5109e47895d0fe837a97396287d5b314e/merged: invalid argument

podman-3.1.0-0.48.dev.gitdec06b1.fc35 on kernel 5.12.0-0.rc0.20210222git31caf8b2a847.158.fc35 (don't bother trying on any 5.11 kernel, those are all completely b0rked). This is 100% reliable, fails every time. I cannot reproduce on f33.

The failing test was added 2020-10-19 by @rhatdan in PR #7908
@rhatdan rhatdan mentioned this issue Feb 26, 2021
Merged
@rhatdan
Copy link
Member

rhatdan commented Feb 26, 2021

@giuseppe I think this could be the new volatile flag?

giuseppe added a commit to giuseppe/storage that referenced this issue Mar 1, 2021
@giuseppe
overlay: fix path to incompat/volatile
53452a6 
overlay creates the directory "$workdir/work/incompat/volatile", not
"$workdir/incompat/volatile".

commit ffe1eb2 introduced the issue.

Closes: containers/podman#9507

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this issue Mar 1, 2021
Merged
@giuseppe
Copy link
Member

giuseppe commented Mar 1, 2021

my bad, I introduced the issue with the support for "volatile".

I've opened a PR to address it: containers/storage#840

giuseppe added a commit to giuseppe/storage that referenced this issue Mar 1, 2021
@giuseppe
overlay: fix path to incompat/volatile
209499f 
overlay creates the directory "$workdir/work/incompat/volatile", not
"$workdir/incompat/volatile".

commit ffe1eb2 introduced the issue.

Closes: containers/podman#9507

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/storage that referenced this issue Mar 1, 2021
@giuseppe
overlay: fix path to incompat/volatile
82731a3 
overlay creates the directory "$workdir/work/incompat/volatile", not
"$workdir/incompat/volatile".

commit ffe1eb2 introduced the issue.

Closes: containers/podman#9507

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/storage that referenced this issue Mar 1, 2021
@giuseppe
overlay: fix path to incompat/volatile
408686b 
overlay creates the directory "$workdir/work/incompat/volatile", not
"$workdir/incompat/volatile".

commit ffe1eb2 introduced the issue.

Closes: containers/podman#9507

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@edsantiago
Copy link
Member Author

Still seeing this in rawhide gating tests. Can we get this vendored into podman?

@giuseppe
Copy link
Member

we need to cut a new release of containers/storage

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2021

https://github.com/containers/storage/releases/tag/v1.28.0

@edsantiago edsantiago mentioned this issue Mar 16, 2021
Closed
@waffshappen waffshappen mentioned this issue Mar 26, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@giuseppe giuseppe

Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

overlay: fix path to incompat/volatile giuseppe/storage
3 participants
@giuseppe @edsantiago @rhatdan