Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-remote build: --rm=false is ignored #9869

Closed
edsantiago opened this issue Mar 29, 2021 · 3 comments · Fixed by #9884 or #10292
Closed

podman-remote build: --rm=false is ignored #9869

edsantiago opened this issue Mar 29, 2021 · 3 comments · Fixed by #9884 or #10292
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

In window 1:

$ ./bin/podman system service --timeout=0

In window 2:

$ cat Dockerfile
FROM alpine
RUN date
RUN echo hello
RUN echo goodbye
$ ../bin/podman-remote build --force-rm=false --layers --rm=false -t foo .
STEP 1: FROM alpine
STEP 2: RUN date
Mon Mar 29 18:28:51 UTC 2021
--> b9328ccce3e
STEP 3: RUN echo hello
hello
--> f5b01f9cb4c
STEP 4: RUN echo goodbye
goodbye
STEP 5: COMMIT foo
--> 9a41527cdb1
9a41527cdb1dc71359791d4db8d5c542c1f4974b0341c3915ebd4b751d27577e
$ buildah containers
CONTAINER ID  BUILDER  IMAGE ID     IMAGE NAME                       CONTAINER NAME

That is: empty output from buildah containers. Expected multiple non-deleted layers:

$ buildah containers
CONTAINER ID  BUILDER  IMAGE ID     IMAGE NAME                       CONTAINER NAME
fa2db0a99cfd     *     302aba9ce190 docker.io/library/alpine:latest  alpine-working-container
5fb1c74a92a2     *     fa3e1b440db3                                  fa3e1b440db32af589c022c212375db64359d7381ed64380ab9f7b095e8b7380-working-container
fd7777c2756d     *     d9c3da18bc3e                                  d9c3da18bc3e5f3db3fcd183cf0d54fa109e136754335cc5c5df2211e6e78da9-working-container
@edsantiago edsantiago added kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Mar 29, 2021
@rhatdan rhatdan self-assigned this Mar 30, 2021
rhatdan added a commit to rhatdan/podman that referenced this issue Apr 2, 2021
Fix handling of SecurityOpts
   LabelOpts
   SeccompProfilePath
   ApparmorProfile

Fix Ulimits

Fixes: containers#9869

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@edsantiago
Copy link
Member Author

I'm pretty confused. This is not fixed, even in 8c0df1c with buildah-v1.20.1-0.20210402144408-36a37402d0c8. And looking at #9884, I see:

        if options.RemoveIntermediateCtrs {
		params.Set("rm", "1")
	}

...but this issue relates to --rm=false, and I'm wondering if there's a default somewhere (I can't find it) such that the above is a NOP, and what we need is to override the default 1? Reopening.

@edsantiago edsantiago reopened this Apr 7, 2021
mheon pushed a commit to mheon/libpod that referenced this issue Apr 16, 2021
Fix handling of SecurityOpts
   LabelOpts
   SeccompProfilePath
   ApparmorProfile

Fix Ulimits

Fixes: containers#9869

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
jmguzik pushed a commit to jmguzik/podman that referenced this issue Apr 26, 2021
Fix handling of SecurityOpts
   LabelOpts
   SeccompProfilePath
   ApparmorProfile

Fix Ulimits

Fixes: containers#9869

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions
Copy link

github-actions bot commented May 8, 2021

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

Still present in 54bed10

rhatdan added a commit to rhatdan/podman that referenced this issue May 10, 2021
Fixes: containers#9869

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/podman that referenced this issue May 10, 2021
Fixes: containers#9869

[NO TESTS NEEDED] Since the podman-remote buildah tests will test this,
and this is clearly correct.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
2 participants