Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes generate kube incorrect when bind-mounting "/" and "/root" #10136

Merged

Conversation

zhangguanzhang
Copy link
Collaborator

Fixes #9764
Signed-off-by: zhangguanzhang zhangguanzhang@qq.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@rhatdan
Copy link
Member

rhatdan commented Apr 26, 2021

LGTM
@haircommander @umohnani8 @vrothberg PTAL

@haircommander
Copy link
Collaborator

LGTM

@umohnani8
Copy link
Member

LGTM, but tests are unhappy

Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
@zhangguanzhang
Copy link
Collaborator Author

all had done

@TomSweeneyRedHat
Copy link
Member

LGTM
and happy green test buttons

@rhatdan
Copy link
Member

rhatdan commented Apr 27, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5baa0ae into containers:master Apr 27, 2021
@zhangguanzhang zhangguanzhang deleted the generate-kube-volume branch April 27, 2021 10:40
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman generate kube produces incorrect configuration when bind-mounting "/" and "/root" simultaneously
7 participants