Revert Patch to relabel if selinux not enabled #10253
Conversation
openshift-ci-robot
added
the
approved
|
@dustymabe PTAL |
|
@rhatdan - we may want to consider keeping the tests and adjusting them to the correct behavior (now that we know what that is). |
|
@tunacado Could you point me back to the original issue that caused us to change the labeling practice. I might have to add a containers.conf option to give you what you want. |
|
Fixes: #10209 |
rhatdan
force-pushed
the
relabel
branch
3 times, most recently
from
48c9645
to
88421fb
Compare
Revert : containers#9895 Turns out that if Docker is in --selinux-enabeled, it still relabels if the user tells the system to, even if running a --privileged container or if the selinux separation is disabled --security-opt label=disable. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhatdan good to merge? /lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
Yes we can merge. But I need feedback from @tunacado about the next step. |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Revert : #9895
Turns out that if Docker is in --selinux-enabeled, it still relabels if
the user tells the system to, even if running a --privileged container
or if the selinux separation is disabled --security-opt label=disable.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com