Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client disconnect check to build handler loop #10295

Merged
merged 1 commit into from
May 10, 2021
Merged

Add client disconnect check to build handler loop #10295

merged 1 commit into from
May 10, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented May 10, 2021

In process of debugging #10154, I added request channel check and logging message to build loop. Unable to recreate build drop issue after this. 68k build iterations without fail.

RE: #10154

Signed-off-by: Jhon Honce jhonce@redhat.com

@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label May 10, 2021
@jwhonce jwhonce self-assigned this May 10, 2021
@jwhonce jwhonce changed the title Add client disconnect to build handler loop Add client disconnect check to build handler loop May 10, 2021
edsantiago
edsantiago approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even if it's a heisenbug

pkg/api/handlers/compat/images_build.go
@@ -553,6 +553,10 @@ loop:
}
}
break loop
case <-r.Context().Done():
cancel()
logrus.Infof("Client disconnect reported for build %q / %q.", registry, query.Dockerfile)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, but my expectation would be to see this as at least a Warn?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edsantiago My thinking is from the service POV, a client disconnecting is not a error condition simply a state change.

@mheon
Copy link
Member

mheon commented May 10, 2021

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@jwhonce
Add client disconnect to build handler loop
290a582 
[NO TESTS NEEDED]
In process of debugging added request channel check and logging message
to build loop. Unable to recreate build drop issue after this. 68k build
iterations without fail.

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2021
@edsantiago
Copy link
Member

/hold

CI isn't finished yet

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2021
@TomSweeneyRedHat
Copy link
Member

@edsantiago I thought if you did a /lgtm while the CI was cranking, the merge wouldn't happen if the CI failed?

@edsantiago
Copy link
Member

I don't know. I was told years ago that slash-lgtm did really really bad things if CI wasn't finished. Something about "cranking" or "churning" or something. Perhaps that bug has been fixed and I just wasn't aware of it. @cevich any idea?

@edsantiago edsantiago removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 76c8577 into containers:master May 10, 2021
@mheon
Copy link
Member

mheon commented May 10, 2021 via email

@edsantiago
Copy link
Member

@jwhonce, so sorry, it is not fixed. This is a run based on master @ 76c8577, which includes this PR.

Unfortunately, there's no way (yet?) to capture the server logs. Should I look into a way to preserve those?

@edsantiago edsantiago mentioned this pull request May 10, 2021
Closed
@cevich
Copy link
Member

cevich commented May 11, 2021

I don't know. I was told years ago that slash-lgtm did really really bad things if CI wasn't finished

Ya, it's safer to assume it's still broken. The bot's configuration is super-duper complex, and shared with the OpenShift team. I'd rather not rock the boat (or even even make it lean slightly).

@edsantiago edsantiago mentioned this pull request Sep 14, 2022
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@jwhonce jwhonce

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jwhonce @mheon @TomSweeneyRedHat @edsantiago @cevich @openshift-merge-robot