Several shell completion fixes #10328
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This is the second time this week that dependabot breaks the CI. Both after #10303 and #10316 the Test Code Consistency check was failing due an change in the go.sum file. How can the original PR pass this test but break for all future PRs until the missing line is added to go.sum? @vrothberg @rhatdan @mheon PTAL |
Luap99
force-pushed
the
completions
branch
2 times, most recently
from
df3abf2 to
183dddb
Compare
|
@Luap99 all kinds of test unhappiness. |
|
@TomSweeneyRedHat The tests are failing because podman.io is down ;( |
|
@Luap99 @TomSweeneyRedHat |
|
@jmguzik This does not interfere. I merged your PR and rebased this one to also add shell completion for network prune --filter. |
|
LGTM |
| @@ -21,14 +21,9 @@ Do not prompt for confirmation. | |||
|
|
|||
| #### **--filter** | |||
|
|
|||
| Filter volumes to be pruned. Volumes can be filtered by the following attributes: | |||
| Filter volumes to be pruned. Volumes can be filtered by the following attribute: | |||
There was a problem hiding this comment.
Is this true? I seem to be able to use every one of those (the removed entries) as an argument to podman volume prune --filter.
There was a problem hiding this comment.
You are right. This was apparently only removed from the compat api endpoint.
Luap99
force-pushed
the
completions
branch
2 times, most recently
from
6e12188 to
b65ef44
Compare
- fix network filters - add prune filters - pod create --share support comma separated namespaces [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
|
LGTM. If you have to push again (please don't re-push just for this), I think future maintainers might appreciate a checkin comment that includes something like "prune --labels and --until are only stubs; implementing actual completion is TBI". |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Also fix the volume prune man page which listed invalid prune filters.