-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support automatic labeling of kube volumes #10339
Conversation
@rhatdan lint is complaining about trailing whitespace. |
Allow users to specify options on the volume mount path. This will trigger relabels of user specifies :z,:Z Also will handle User Relabels if the user specifies :U Fixes: containers#9371 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
run_podman play kube - < $PODMAN_TMPDIR/test.yaml | ||
if [ -e /usr/sbin/selinuxenabled -a /usr/sbin/selinuxenabled ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not do what you think it does (the /usr/sbin/selinuxenabled
on the right-hand side is not executed, it is an empty-string check (equivalent to test -n /usr/sbin/selinuxenabled
). I can fix this in a followup PR if you need to merge this urgently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this same check in other locations. But let's fix it elsewhere so we can get this merged and move along.
/lgtm |
LGTM |
Allow users to specify options on the volume mount path.
This will trigger relabels of user specifies :z,:Z
Also will handle User Relabels if the user specifies :U
Fixes: #9371
Signed-off-by: Daniel J Walsh dwalsh@redhat.com