Support DeviceCgroupRules to actually get added. #10895
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rhatdan
force-pushed
the
devices
branch
4 times, most recently
from
a095484 to
d8f5f51
Compare
|
Lots of Red test unhappiness. |
pkg/specgen/specgen.go
Outdated
| @@ -239,6 +239,9 @@ type ContainerStorageConfig struct { | |||
| // Devices are devices that will be added to the container. | |||
| // Optional. | |||
| Devices []spec.LinuxDevice `json:"devices,omitempty"` | |||
| // DeviceCGroupRule are device cgroup rules that allow containers | |||
| // to use additional types of devices. | |||
| DeviceCGroupRule []string `json:"device_cgroup_rule,omitempty"` | |||
There was a problem hiding this comment.
Can we do the parsing on the frontend, so we can pass a struct here (including the type, path, and access permissions)?
There was a problem hiding this comment.
Generally speaking, we try to parse in the frontend to the greatest extent possible, so the server does not have to do much validation of the contents of specgen.
Fixes: containers#10302 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
LGTM |
|
LGTM, just a general note: wondering if in the future we should look to combine all |
github-actions
bot
added
the
locked - please file new issue/PR
Fixes: #10302
Signed-off-by: Daniel J Walsh dwalsh@redhat.com