Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootless: avoid zombie process on first launch #11073

Merged
merged 1 commit into from
Jul 29, 2021
Merged

rootless: avoid zombie process on first launch #11073

merged 1 commit into from
Jul 29, 2021

Conversation

giuseppe
Copy link
Member

avoid a zombie process if on the first launch Podman creates a long
living process, such as "podman system service -t 0".

The r variable was overriden thus causing the waitpid to fail and
not clean up the intermediate process.

Closes: #10575

[NO TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@giuseppe giuseppe mentioned this pull request Jul 29, 2021
Closed
@giuseppe
rootless: avoid zombie process on first launch
724d048 
avoid a zombie process if on the first launch Podman creates a long
living process, such as "podman system service -t 0".

The `r` variable was overriden thus causing the waitpid to fail and
not clean up the intermediate process.

Closes: containers#10575

[NO TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the fix-zombie-process-first-run branch from 3ee3964 to 724d048 Compare July 29, 2021 09:07
vrothberg
vrothberg reviewed Jul 29, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @giuseppe !

@vrothberg
Copy link
Member

@containers/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Jul 29, 2021

/lgtm
/hold
Don't know what is going on with the CI system.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
@rhatdan
Copy link
Member

rhatdan commented Jul 29, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0f42cce into containers:main Jul 29, 2021
@PavelSosin-320
Copy link

@giuseppe Hopefully, PR 10575 will calm the following issue:

systemd[133]: Starting PodmanAPI Service for Rootless users...
podman[279]: 2021-08-03 08:19:42.6111998 +0300 IDT m=+0.180908901 system refresh
systemd[133]: podman.service: Got notification message from PID 279, but reception only permitt>
that appears when rootless user starts podman using systemd unit as "Notify" type service:
[Service]
Type=notify
...
Indeed, the main process is Main PID: 269 (podman), So systemd doesn't expect any other notifications.

@edsantiago edsantiago mentioned this pull request Aug 31, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The command Podman system service creates 2 processes that are hard to die.
5 participants
@giuseppe @vrothberg @rhatdan @PavelSosin-320 @openshift-merge-robot