Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Make GVPROXY_PATH to locate gvproxy #11480

Closed
wants to merge 1 commit into from

Conversation

jonpspri
Copy link
Contributor

@jonpspri jonpspri commented Sep 8, 2021

Presented as an alternative to PR #11449

Rather than do backflips in the code to locate gvproxy, use a
build-time variable to set the location. That variable can default to
/usr/libexec but other build packages (e.g. Homebrew) can set it to
something of their liking.

I'll take no offense if the consensus is that we do not want to pollute
the build, but we should likely add a runtime configuration parameter as an
alternative in that case.

Fixes: #11226

Signed-off-by: Jonathan Springer jonpspri@gmail.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonpspri
To complete the pull request process, please assign saschagrunert after the PR has been reviewed.
You can assign the PR to them by writing /assign @saschagrunert in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonpspri
Copy link
Contributor Author

jonpspri commented Sep 8, 2021

@Luap99
Copy link
Member

Luap99 commented Sep 8, 2021

I don't like this as compile option, I created containers/common#758 to add this to the containers.conf file. With that everyone can configure this without having to recompile.

Presented as an alternative to PR containers#11449

Rather than do backflips in the code to locate `gvproxy`, use a
build-time variable to set the location.  That variable can default to
`/usr/libexec` but other build packages (_e.g._ Homebrew) can set it to
something of their liking.

I'll take no offense if the consensus is that we do not want to pollute
the build, but we should likely add a runtime configuration parameter as an
alternative in that case.

Fixes: containers#11226

Signed-off-by: Jonathan Springer <jonpspri@gmail.com>
@vrothberg
Copy link
Member

I don't like this as compile option, I created containers/common#758 to add this to the containers.conf file. With that everyone can configure this without having to recompile.

I concur with @Luap99. I prefer this be a runtime option rather than a compile-time option.

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2021

Lets do this at runtime.

@rhatdan rhatdan closed this Sep 9, 2021
@StephenWithPH
Copy link

Linking to NixOS/nixpkgs#141041 (comment) . Build-time linking would have been quite handy for packaging podman in nix.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
5 participants