Refactor API server emphasis on logging #11517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
jwhonce
force-pushed
the
issues/10053
branch
from
2d2ef1b to
4541b0d
Compare
Luap99
reviewed
Sep 10, 2021
mheon
reviewed
Sep 10, 2021
jwhonce
force-pushed
the
issues/10053
branch
2 times, most recently
from
1b94f9c to
4729ebd
Compare
jwhonce
added
HTTP API
jwhonce
force-pushed
the
issues/10053
branch
3 times, most recently
from
254bacd to
ae32276
Compare
* To aid in debugging log API request and response bodies at trace level. Events can be correlated using the X-Reference-Id. * Server now echos X-Reference-Id from client if set, otherwise generates an unique id. * Move logic for X-Reference-Id into middleware * Change uses of Header.Add() to Set() when setting Content-Type * Log API operations in Apache format using gorilla middleware * Port server code to use BaseContext and ConnContext Fixes containers#10053 Signed-off-by: Jhon Honce <jhonce@redhat.com>
jwhonce
force-pushed
the
issues/10053
branch
from
ae32276 to
deaf969
Compare
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
level. Events can be correlated using the X-Reference-Id.
generates an unique id.
Fixes #10053
Signed-off-by: Jhon Honce jhonce@redhat.com