Add no-trunc support to podman-events #11603
Conversation
openshift-ci
bot
added
approved
openshift-ci
bot
removed
the
needs-rebase
| @@ -15,11 +15,11 @@ Displays locally stored images, their names, and their IDs. | |||
|
|
|||
| ## OPTIONS | |||
|
|
|||
| #### **--all**, **-a** | |||
| #### **--all**, **-a**=*true|false* | |||
There was a problem hiding this comment.
I don't think we should add this to boolean options.
At least that is what is written in MANPAGE_SYNTAX
If the arguments behind the OPTION are boolean, it is not shown behind the OPTION itself. The default boolean argument is shown in the same way normal default arguments are displayed.
Example: The default is false.
There was a problem hiding this comment.
I don't know, I am fine with removing them, but I was striving for consistency.
| @@ -668,10 +668,10 @@ Valid _mode_ values are: | |||
| - **ns:**_path_: Path to a network namespace to join. | |||
| - **private**: Create a new namespace for the container. This will use the **bridge** mode for rootfull containers and **slirp4netns** for rootless ones. | |||
| - **slirp4netns[:OPTIONS,...]**: use **slirp4netns**(1) to create a user network stack. This is the default for rootless containers. It is possible to specify these additional options: | |||
| - **allow_host_loopback=true|false**: Allow the slirp4netns to reach the host loopback IP (`10.0.2.2`, which is added to `/etc/hosts` as `host.containers.internal` for your convenience). Default is false. | |||
| - **allow_host_loopback: Allow the slirp4netns to reach the host loopback IP (`10.0.2.2`, which is added to `/etc/hosts` as `host.containers.internal` for your convenience). Default is false. | |||
There was a problem hiding this comment.
Missing a ** after allow_host_loopback
There was a problem hiding this comment.
This true|false in the network description should stay. It is not a boolean flag here and therefore must be set.
Standardize on no-trunc through the code. Alias notruncate where necessary. Standardize on the man page display of no-trunc. Fixes: containers#8941 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Standardize on no-trunc through the code.
Alias notruncate where necessary.
Standardize on the man page display of no-trunc.
Fixes: #8941
Signed-off-by: Daniel J Walsh dwalsh@redhat.com