Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman volumes #11699

Closed
wants to merge 4 commits into from
Closed

Podman volumes #11699

wants to merge 4 commits into from

Conversation

n0rig
Copy link

@n0rig n0rig commented Sep 22, 2021

No description provided.

afbjorklund and others added 3 commits September 12, 2021 20:58
Allow using the built-in 9pfs feature of qemu,
mounting host directories into vm mountpoints.

The volumes are generic, the mounts are specific.

Wait for the machine to be "running", otherwise
the SSH function might throw an error instead.

Increase the default msize from 8 KiB to 128 KiB

[NO TESTS NEEDED]

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: n0rig
To complete the pull request process, please assign jwhonce after the PR has been reviewed.
You can assign the PR to them by writing /assign @jwhonce in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Josh Giron <jgiron@vmware.com>
@rhatdan
Copy link
Member

rhatdan commented Sep 22, 2021

Please squash your commits into a single commit. Looks like you have included a merge commit.

Please add more test to explain the commit.

Should we have options for sshfs versus 9p?

@@ -47,6 +47,10 @@ Defaults to `testing`.

Memory (in MB).

#### **--volume**, **-v**=*source:target*

Mounts a volume from `source` to `target`.
Copy link
Member

@rhatdan rhatdan Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a much richer explanation.
Something like:

The source volume will become available to local podman commands.  If you mounted your home 
directory into the podman machine. Then `podman run  -v /home/dwalsh:/home/dwalsh ...` commands
will be able to mount content from these machine directories into containers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to comment on PR #11454 instead, where this commit was taken from

@n0rig
Copy link
Author

n0rig commented Sep 22, 2021

Hey, I just wanted to reproduce the build issue seen on @afbjorklund's PR and see where I can contribute to his PR. Apologies for the confusion as I thought this was a draft PR.

@n0rig n0rig closed this Sep 22, 2021
@afbjorklund
Copy link
Contributor

Should we have options for sshfs versus 9p?

Only 9p (and smb) are included with qemu, so using reverse sshfs would need an external implementation like in sshocker

The volume flag should be usable with other implementations (thus the "type"), but the mounts are specific to virtfs right now

But please continue the discussion on #8016

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants