-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podman volumes #11699
Podman volumes #11699
Conversation
Allow using the built-in 9pfs feature of qemu, mounting host directories into vm mountpoints. The volumes are generic, the mounts are specific. Wait for the machine to be "running", otherwise the SSH function might throw an error instead. Increase the default msize from 8 KiB to 128 KiB [NO TESTS NEEDED] Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: n0rig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Josh Giron <jgiron@vmware.com>
Please squash your commits into a single commit. Looks like you have included a merge commit. Please add more test to explain the commit. Should we have options for sshfs versus 9p? |
@@ -47,6 +47,10 @@ Defaults to `testing`. | |||
|
|||
Memory (in MB). | |||
|
|||
#### **--volume**, **-v**=*source:target* | |||
|
|||
Mounts a volume from `source` to `target`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a much richer explanation.
Something like:
The source volume will become available to local podman commands. If you mounted your home
directory into the podman machine. Then `podman run -v /home/dwalsh:/home/dwalsh ...` commands
will be able to mount content from these machine directories into containers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to comment on PR #11454 instead, where this commit was taken from
Hey, I just wanted to reproduce the build issue seen on @afbjorklund's PR and see where I can contribute to his PR. Apologies for the confusion as I thought this was a draft PR. |
Only 9p (and smb) are included with qemu, so using reverse sshfs would need an external implementation like in sshocker The volume flag should be usable with other implementations (thus the "type"), but the mounts are specific to virtfs right now But please continue the discussion on #8016 |
No description provided.