-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO TESTS NEEDED] Ignore removed containers #11820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be handled somewhere in the backend. This fix could loop forever and does not cover api users.
Should break out once database state is consistent, but you are right it does not cover the API just the CLI. I'll take a look to see if we have a single path to fix it all. |
I think here would be good: Line 65 in c6a896b
|
* Ignore condition when containers are removed while listing them for ps output. No tests added at this time as they would create a race condition for CI. * Updated godocs See containers#11810 for reproducer. Fixes containers#11810 Signed-off-by: Jhon Honce <jhonce@redhat.com>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ignore condition when containers are removed while listing them for
ps output.
No tests added at this time as they would create a race condition for
CI.
See #11810 for reproducer.
Fixed up some godoc errors.
Fixes #11810
Signed-off-by: Jhon Honce jhonce@redhat.com
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: