Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TESTS NEEDED] Ignore removed containers #11820

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Sep 30, 2021

Ignore condition when containers are removed while listing them for
ps output.

No tests added at this time as they would create a race condition for
CI.

See #11810 for reproducer.

Fixed up some godoc errors.

Fixes #11810

Signed-off-by: Jhon Honce jhonce@redhat.com

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Sep 30, 2021
@jwhonce jwhonce requested a review from baude September 30, 2021 23:14
@jwhonce jwhonce self-assigned this Sep 30, 2021
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled somewhere in the backend. This fix could loop forever and does not cover api users.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@jwhonce
Copy link
Member Author

jwhonce commented Oct 1, 2021

This should be handled somewhere in the backend. This fix could loop forever and does not cover api users.

Should break out once database state is consistent, but you are right it does not cover the API just the CLI. I'll take a look to see if we have a single path to fix it all.

@Luap99
Copy link
Member

Luap99 commented Oct 1, 2021

This should be handled somewhere in the backend. This fix could loop forever and does not cover api users.

Should break out once database state is consistent, but you are right it does not cover the API just the CLI. I'll take a look to see if we have a single path to fix it all.

I think here would be good:

listCon, err := ListContainerBatch(runtime, con, options)

* Ignore condition when containers are removed while listing them for
ps output.

  No tests added at this time as they would create a race condition for
CI.

* Updated godocs

See containers#11810 for reproducer.

Fixes containers#11810

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Oct 2, 2021

LGTM
@containers/podman-maintainers PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99
Copy link
Member

Luap99 commented Oct 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b9d8c63 into containers:main Oct 2, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman ps sometimes fails if container process is stopped and removed during call
5 participants