Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor podman search to be more code friendly #11924

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Oct 11, 2021

  • JSON and API description fields are no longer truncated. Formatting
    moved to client, better support of MVP.
  • --no-trunc now defaults to true
  • Updated tests for changes

Closes #11894

Signed-off-by: Jhon Honce jhonce@redhat.com

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@jwhonce jwhonce added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 11, 2021
@jwhonce jwhonce self-assigned this Oct 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think [NO NEW TESTS NEEDED] needs to be in caps

@TomSweeneyRedHat
Copy link
Member

Changes look OK to me, but same questions here as in #11892. Do we mess up expected behavior, especially so for someone who may have built a script based on the prior return?

@vrothberg
Copy link
Member

LGTM, but I think [NO NEW TESTS NEEDED] needs to be in caps

I actually think that the --no-trunc=true could be checked for in a test. For instance, by making sure that no cell ends with ....

@vrothberg
Copy link
Member

Changes look OK to me, but same questions here as in #11892. Do we mess up expected behavior, especially so for someone who may have built a script based on the prior return?

We'll only find out once we ship but 4.0 is the next chance we'll have. I don't think that anyone would bark after this change here though as I find it unlikely that folks rely on things being truncated by default.

* JSON and API description fields are no longer truncated. Formatting
  moved to client, better support of MVP.
* --no-trunc now defaults to true
* Updated tests for changes

Closes containers#11894

Signed-off-by: Jhon Honce <jhonce@redhat.com>
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
@openshift-merge-robot openshift-merge-robot merged commit 72e87c0 into containers:main Oct 12, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman search should return the entire description in the --format json
5 participants