-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor podman search to be more code friendly #11924
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think [NO NEW TESTS NEEDED] needs to be in caps
Changes look OK to me, but same questions here as in #11892. Do we mess up expected behavior, especially so for someone who may have built a script based on the prior return? |
I actually think that the --no-trunc=true could be checked for in a test. For instance, by making sure that no cell ends with |
We'll only find out once we ship but 4.0 is the next chance we'll have. I don't think that anyone would bark after this change here though as I find it unlikely that folks rely on things being truncated by default. |
* JSON and API description fields are no longer truncated. Formatting moved to client, better support of MVP. * --no-trunc now defaults to true * Updated tests for changes Closes containers#11894 Signed-off-by: Jhon Honce <jhonce@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
moved to client, better support of MVP.
Closes #11894
Signed-off-by: Jhon Honce jhonce@redhat.com
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: