image lookup: do not match *any* tags #12010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
WIP for now: want to throw it at CI to see which tests break (and need adjustment). |
vrothberg
force-pushed
the
fix-11964
branch
5 times, most recently
from
7b245c2
to
3e20581
Compare
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
|
@rhatdan, @giuseppe , I'm seeing some c/storage changes causing failures: |
vrothberg
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@containers/podman-maintainers PTAL |
|
I think you have to rebase to remove the broken static build test. |
For reasons buried in the history of Podman, looking up an untagged image would match any tag of matching image. For instance, looking up centos would match a local image centos:foobar. Change that behavior to only match the latest tag. Fix: containers#11964 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
|
Green and happy, @containers/podman-maintainers PTAL |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons buried in the history of Podman, looking up an untagged
image would match any tag of matching image. For instance,
looking up
centoswould match a local imagecentos:foobar.Docker only looks for
centos:latest.Fix: #11964
Signed-off-by: Valentin Rothberg rothberg@redhat.com