Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change podman connection list to use default field #12027

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 18, 2021

Stop using "*" to indicate default. Add default field to make
it more obvios and the json field more machine usable.

Fixes: #12019

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Stop using "*" to indicate default.  Add default field to make
it more obvios and the json field more machine usable.

Fixes: containers#12019

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@mheon
Copy link
Member

mheon commented Oct 18, 2021

LGTM

@jwhonce
Copy link
Member

jwhonce commented Oct 19, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
@openshift-merge-robot openshift-merge-robot merged commit 139dca0 into containers:main Oct 19, 2021
This was referenced Oct 19, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman system connection ls --format json: remove star from default Name please
4 participants