Set DOCKER_HOST in the VM

[matejvasek]

Some tools might expect the envvar is set.

[afbjorklund]

@matejvasek : There is no need to set the DOCKER_SOCK, the default will still work.

The podman-docker package uses the tmpfiles workaround, to create a symlink:

/var/run/docker.sock -> /run/podman/podman.sock

Currently it is copied to /etc/tmpfiles.d/podman-docker.conf instead of using the RPM: b3307bc

https://github.com/containers/podman/blob/main/contrib/systemd/system/podman-docker.conf

---

The environment variable is used for rootless containers: (so user "core", not user "root")

https://docs.docker.com/engine/security/rootless/#expose-docker-api-socket-through-ssh

So that is the one you should configure, but the default socket doesn't need the variable.

And of course this is only needed for compat socket, podman-remote requires a path.

DOCKER_HOST=ssh://root@localhost:35503
CONTAINER_HOST=ssh://root@localhost:35503/run/podman/podman.sock

[matejvasek]

@afbjorklund OK rootfull should work without setting the environment variable since the socket is at default location. But for rootless it's useful. And I believe this shouldn't hurt anybody because podman info -f "{{.Host.RemoteSocket.Path}}" prints correct path depending on user. So it sets DOCKER_HOST correctly for both root and core user to their respective socket.

[matejvasek]

I am using a software that is mounting socket into running container. So I need the DOCKER_HOST environment variable to be set properly for each user so I know what socket mount.

[matejvasek]

For rootfull it's not really issue if the symlink exists.

[matejvasek]

I could move the script to /home/core/.bashrc.d so it's set only for non-root, but as I mentioned above having it set also for root shoudn't be issue.

[mheon]

@baude PTAL

[rhatdan]

I would set it for both cases, LGTM

[TomSweeneyRedHat]

LGTM too, but would like a @baude head nod

[matejvasek]

@baude PTAL

[baude]

/lgtm

[rhatdan]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment