Fix rootless networking with userns and ports #12227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mheon
reviewed
Nov 8, 2021
| @@ -290,7 +290,7 @@ func (c *Container) handleRestartPolicy(ctx context.Context) (_ bool, retErr err | |||
|
|
|||
| // setup slirp4netns again because slirp4netns will die when conmon exits | |||
| if c.config.NetMode.IsSlirp4netns() { | |||
| err := c.runtime.setupSlirp4netns(c) | |||
| err := c.runtime.setupSlirp4netns(c, c.state.NetNS) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Any reason 293 and 294 are separate lines?
|
LGTM overall |
|
looks like some test unhappiness @Luap99 |
A rootless container created with a custom userns and forwarded ports did not work. I refactored the network setup to make the setup logic more clear. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
/lgtm |
This was referenced Nov 11, 2021
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A rootless container created with a custom userns and forwarded ports
did not work. I refactored the network setup to make the setup logic
more clear.
How to verify it
podman run -it --rm --userns keep-id --network bridge -p 8080:8080 alpine nc -l -p 8080echo test | nc 127.0.0.1 8080Which issue(s) this PR fixes:
Special notes for your reviewer: