Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude already built sources for static build #12235

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Exclude already built sources for static build #12235

merged 1 commit into from
Nov 9, 2021

Conversation

saschagrunert
Copy link
Member

What this PR does / why we need it:

We now do not copy the bin directory to the target nix sources to avoid skipping the build because "everything is up to date".

How to verify it

> make
> nix-build nix
> ldd result/bin/podman
        not a dynamic executable

Which issue(s) this PR fixes:

Fixes #12198

Special notes for your reviewer:

None

@saschagrunert
Exclude already built sources for static build
d0b502f 
We now do not copy the `bin` directory to the target nix sources to
avoid skipping the build because "everything is up to date".

Fixes containers#12198

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2021
@saschagrunert saschagrunert mentioned this pull request Nov 9, 2021
Closed
giuseppe
giuseppe approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Nov 9, 2021

I don't know why the optional release test triggered, but we can disregard as this is not a release.

@mheon
Copy link
Member

mheon commented Nov 9, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit c996d9f into containers:main Nov 9, 2021
@saschagrunert saschagrunert deleted the fix-static-build branch November 9, 2021 15:33
@cevich
Copy link
Member

cevich commented Nov 9, 2021

Thanks @saschagrunert

This was referenced Nov 10, 2021
Closed
Closed
Closed
This was referenced Nov 30, 2021
Closed
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static Build for #11728 isn't static
5 participants
@saschagrunert @mheon @cevich @giuseppe @openshift-merge-robot