-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compat: Add subnet mask behind IP address to match Docker API #12328
Conversation
364adae
to
ab17226
Compare
@serverwentdown thanks for the PR. Our CI requires a test to be added with a PR. Could you create one or update one? It would be good to test that the format is as you want it to be. Changes LGTM otherwise, but I'm not sure if there are dependencies elsewhere for the current format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, could you also add a test to https://github.com/containers/podman/tree/main/test/apiv2?
@Luap99 |
ab17226
to
71f870e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, serverwentdown The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @serverwentdown, unfortunately you have to rebase to the latest main branch in order to pass the CI tests. |
Signed-off-by: Ambrose Chua <ambrose@hey.com>
71f870e
to
ab56a7c
Compare
/lgtm |
Forcing merge to save the planet. |
Thanks @serverwentdown |
No plans for that now. |
Given when this merged, I probably already attempted to backport it to v3.4.2 or v3.4.3, but the patch had cherry-pick conflicts against that branch so I moved on. |
Has this feature been added in v4? Been waiting on this for k3d on podman. |
@geraldwuhoo It should be in v4.0 |
What this PR does / why we need it:
Mismatch between Podman and Docker APIs when listing network containers.
How to verify it
On both Docker and Podman, create a container on a network and run:
Docker (20.10.10):
Podman:
Which issue(s) this PR
Fixes: None
(Sidenote: I'm working on compatibility with
k3d
)Special notes for your reviewer: