Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support hosts without /etc/hosts #12668

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

vrothberg
Copy link
Member

Fixes: #12667
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@containers/podman-maintainers PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021
@baude
Copy link
Member

baude commented Dec 21, 2021

LGTM

1 similar comment
@umohnani8
Copy link
Member

LGTM

Fixes: containers#12667
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg
Copy link
Member Author

Rebased, PTanotherL

@vrothberg
Copy link
Member Author

@flouthoc @giuseppe PTAL

@rhatdan
Copy link
Member

rhatdan commented Dec 22, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3280204 into containers:main Dec 22, 2021
@flouthoc
Copy link
Collaborator

LGTM for the record.

@vrothberg vrothberg deleted the fix-12667 branch December 22, 2021 11:58
@martinpitt
Copy link
Contributor

Superb, thank you for the super-fast fix!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman run fails without /etc/hosts
8 participants