Use the InfraImage defined in containers.conf #12780
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| podGen.InfraImage = imageName | ||
| podGen.InfraContainerSpec = specgen.NewSpecGenerator(imageName, false) | ||
| podGen.InfraContainerSpec.RawImageName = imageName | ||
| podGen.InfraContainerSpec = specgen.NewSpecGenerator("", false) |
There was a problem hiding this comment.
will this populate the image name in the spec before passing it to the remote client if that path is called? Looking at NewSpecGenerator it looks like it will just pass the empty string
There was a problem hiding this comment.
Yes it should be empty string, and allow the server side to decide, based on the contents of containers.conf.
|
LGTM once you can tame the tests |
Remove hard code use of the DefaultInfraImage and rely on getting this from containers.conf. Fixes: containers#12771 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Remove hard code use of the DefaultInfraImage and rely on
getting this from containers.conf.
Fixes: #12771
Signed-off-by: Daniel J Walsh dwalsh@redhat.com