Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement env parsing on Windows #12928

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Implement env parsing on Windows #12928

merged 1 commit into from
Jan 20, 2022

Conversation

n1hility
Copy link
Member

@n1hility n1hility commented Jan 19, 2022 •
edited
Loading

Fixes #12056
Also, enables existing parsing logic for all Unix derived OSs

C:\Users\User>.\podman run -e FOO=bar alpine env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
TERM=xterm
container=podman
FOO=bar
HOME=/root
HOSTNAME=4d698c93c8f9

[NO NEW TESTS NEEDED], no win CI yet

@n1hility n1hility mentioned this pull request Jan 19, 2022
Merged
4 tasks
@n1hility
Implement env parsing on Windows
4693fc6 
Fixes containers#12056
Also, enables existing parsing logic for all Unix derived OSs

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Jan 19, 2022

/approve
LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n1hility, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
ashley-cui
ashley-cui reviewed Jan 20, 2022
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit 206e57e into containers:main Jan 20, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

Assignees

@ashley-cui ashley-cui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman-remote on windows doesn't send environment variables passed with --env to remote
4 participants
@n1hility @rhatdan @ashley-cui @openshift-merge-robot