Add GetPodStats to varlink #1319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baude
reviewed
Aug 21, 2018
| pod, err := i.Runtime.LookupPod(name) | ||
| if err != nil { | ||
| return call.ReplyPodNotFound(name) | ||
| } |
There was a problem hiding this comment.
should we be vetting that the container is running?
There was a problem hiding this comment.
Currently GetContainerStats doesn't. If you think it should, both should be updated. WDYT
There was a problem hiding this comment.
If the container isn't running it just returns all 0s. I'm thinking filtering on running is probably best for both.
|
bot, retest this please |
1 similar comment
|
bot, retest this please |
Signed-off-by: haircommander <pehunt@redhat.com>
haircommander
force-pushed
the
pod-varlink-3
branch
from
8f6eb84 to
9792eb7
Compare
jwhonce
reviewed
Aug 22, 2018
cmd/podman/varlink/io.podman.varlink
Outdated
| @@ -441,7 +441,7 @@ method ExportContainer(name: string, path: string) -> (tarfile: string) | |||
|
|
|||
| # GetContainerStats takes the name or ID of a container and returns a single ContainerStats structure which | |||
| # contains attributes like memory and cpu usage. If the container cannot be found, a | |||
| # [ContainerNotFound](#ContainerNotFound) error will be returned. | |||
| # [ContainerNotFound](#ContainerNotFound) error will be returned. If the container is not running, an error will be returned. | |||
There was a problem hiding this comment.
Would be nice to document which error was returned if container is not running.
haircommander
force-pushed
the
pod-varlink-3
branch
2 times, most recently
from
a1ea209 to
0e4b75a
Compare
This results in some functionality changes: If a ErrCtrStateInvalid is returned to GetPodStats, the container is ommitted from the stats. As such, if an empty slice of Container stats are returned to GetPodStats in varlink, an error will occur. GetContainerStats will return the ErrCtrStateInvalid as well. Finally, if ErrCtrStateInvalid is returned to the podman stats call, the container will be ommitted from the stats. Signed-off-by: haircommander <pehunt@redhat.com>
haircommander
force-pushed
the
pod-varlink-3
branch
from
0e4b75a to
b7a9bf4
Compare
|
Happy tests and comments addressed. @mheon @baude @TomSweeneyRedHat @jwhonce @rhatdan @umohnani8 PTAL :) |
|
LGTM |
|
📌 Commit b7a9bf4 has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b7a9bf4 has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 23, 2018
This results in some functionality changes: If a ErrCtrStateInvalid is returned to GetPodStats, the container is ommitted from the stats. As such, if an empty slice of Container stats are returned to GetPodStats in varlink, an error will occur. GetContainerStats will return the ErrCtrStateInvalid as well. Finally, if ErrCtrStateInvalid is returned to the podman stats call, the container will be ommitted from the stats. Signed-off-by: haircommander <pehunt@redhat.com> Closes: #1319 Approved by: baude
|
☀️ Test successful - status-papr |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: haircommander pehunt@redhat.com