Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman search: truncate by default #14047

Merged
merged 1 commit into from
Apr 28, 2022
Merged

podman search: truncate by default #14047

merged 1 commit into from
Apr 28, 2022

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Apr 28, 2022 •
edited by edsantiago
Loading

Truncate by default to avoid long descriptions from rendering the output
unreadable.

[NO NEW TESTS NEEDED]

Fixes: #14044
Signed-off-by: Valentin Rothberg vrothberg@redhat.com

Results from `podman search` are now truncated by default

@vrothberg
podman search: truncate by default
ea1fcd7 
Truncate by default to avoid long descriptions from rendering the output
unreadable.

[NO NEW TESTS NEEDED]

Fixes: containers#14044
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@vrothberg vrothberg mentioned this pull request Apr 28, 2022
Closed
Luap99
Luap99 reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc
Copy link
Collaborator

LGTM, would this re-open this though #11894 ?

@vrothberg
Copy link
Member Author

LGTM, would this re-open this though #11894 ?

That's covered by https://github.com/containers/podman/pull/14047/files#diff-e630e7c606f9638e83ab093edd9087837d7e7c2d05d1b25999d0b630f4c92174L146

@vrothberg
Copy link
Member Author

Ready to merge

@rhatdan
Copy link
Member

rhatdan commented Apr 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2b8cafc into containers:main Apr 28, 2022
@vrothberg vrothberg deleted the fix-14044 branch April 28, 2022 11:23
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman outputs a lot of logs
5 participants
@vrothberg @flouthoc @rhatdan @Luap99 @openshift-merge-robot