kube: honor pod security context IDs #14167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
rhatdan
reviewed
May 9, 2022
rhatdan
reviewed
May 9, 2022
pkg/domain/infra/abi/play.go
Outdated
| LogDriver: options.LogDriver, | ||
| LogOptions: options.LogOptions, | ||
| Labels: labels, | ||
| PodSecurityContext: podYAML.Spec.SecurityContext, |
rhatdan
reviewed
May 9, 2022
|
LGTM other then a couple of sort requests. |
giuseppe
force-pushed
the
play-kube-honor-pod-security-context
branch
from
4bbe511
to
36fb52a
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
If the RunAsUser, RunAsGroup, SupplementalGroups settings are not overriden in the container security context, then take the value from the pod security context. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
play-kube-honor-pod-security-context
branch
from
36fb52a
to
9e1ee08
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
fwiesel
added a commit
to fwiesel/podman
that referenced
this pull request
Jun 29, 2023
With PR containers#14167, the pod-level security Context ID are supported, while the markdown says it isn't. This patch fixes it. ``` None ``` Signed-off-by: Fabian Wiesel <fwiesel@users.noreply.github.com>
ashley-cui
pushed a commit
to ashley-cui/podman
that referenced
this pull request
Jul 13, 2023
With PR containers#14167, the pod-level security Context ID are supported, while the markdown says it isn't. This patch fixes it. ``` None ``` Signed-off-by: Fabian Wiesel <fwiesel@users.noreply.github.com>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the RunAsUser, RunAsGroup, SupplementalGroups settings are not overriden in the container security context, then take the value from the pod security context.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com
Does this PR introduce a user-facing change?