Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test c/common errors wrap PR #14753

Closed
wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2022

@saschagrunert: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@Luap99
Copy link
Member

Luap99 commented Jun 28, 2022

I think this requires a similar change here in podman before we can merge the common changes (and likely for other c/common users such as skopeo/buildah). Podman checks with errors.Cause() which does not work with errors created/wrapped with fmt.Errorf()

@saschagrunert
Copy link
Member Author

Ugh, this is going to take a while. I can probably work tomorrow on it :)

@Luap99
Copy link
Member

Luap99 commented Jun 28, 2022

Ugh, this is going to take a while. I can probably work tomorrow on it :)

Sure, I remember looking at this a while ago but I gave up quickly because of the huge amount of changes required.
I think it is easier to start this in podman because this way it should work without the common changes, github.com/pkg/errors errors implement the unwrap interface so errors.Is() will work with them.

@saschagrunert saschagrunert deleted the c-common-errors branch June 29, 2022 08:45
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants