Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test c/common errors wrap PR #14869

Closed
wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

Testing vendored code from containers/common#1077

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@saschagrunert: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
@Luap99
Copy link
Member

Luap99 commented Jul 8, 2022

Looks like there is an actual bug:

# # podman-remote --url unix:/tmp/podman_tmp_iOxu run --name ignore-me --name my-container quay.io/libpod/testimage:20220615 true
         # Error: error preparing container 44d2fe141087e7dd6cb40123e55c96b42fa5823c82edd0adddc45d2b2ed0631b for attach: install profile containers-default-0.49.0-dev: generate default profile into pipe: execute compiled profile: %!w(<nil>)

@saschagrunert
Copy link
Member Author

Thanks, updated the PR with a new c/common revision.

@saschagrunert
Copy link
Member Author

Found another bug, fixing with the next push.

@saschagrunert
Copy link
Member Author

Alright, the bud tests will require the latest buildah.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jul 12, 2022

Mostly green now, giving it another test with latest buildah and c/storage.

@saschagrunert saschagrunert force-pushed the c-common-test branch 2 times, most recently from b813ecd to b61c554 Compare July 12, 2022 10:53
@saschagrunert saschagrunert added the bloat_approved Approve a PR in which binary file size grows by over 50k label Jul 12, 2022
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert deleted the c-common-test branch July 13, 2022 07:03
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants