Update vendor of containers/storage and run codespell. #14892
Conversation
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
LGTM |
|
Looks like there is a regression in c/storage, most tests are failing. |
|
@giuseppe @saschagrunert PTAL |
| @@ -258,7 +258,7 @@ test/version/version: version/version.go | |||
|
|
|||
| .PHONY: codespell | |||
| codespell: | |||
| codespell -S bin,vendor,.git,go.sum,.cirrus.yml,"RELEASE_NOTES.md,*.xz,*.gz,*.ps1,*.tar,swagger.yaml,*.tgz,bin2img,*ico,*.png,*.1,*.5,copyimg,*.orig,apidoc.go" -L uint,iff,od,seeked,splitted,marge,ERRO,hist,ether -w | |||
| codespell -S bin,vendor,.git,go.sum,.cirrus.yml,"RELEASE_NOTES.md,*.xz,*.gz,*.ps1,*.tar,swagger.yaml,*.tgz,bin2img,*ico,*.png,*.1,*.5,copyimg,*.orig,apidoc.go" -L pullrequest,uint,iff,od,seeked,splitted,marge,erro,hist,ether -w | |||
There was a problem hiding this comment.
is the "ERRO" to "erro" change correct?
There was a problem hiding this comment.
Yes, this gets codespell to stop channing ERRO->ERROR, For some reason capitalized it is ignored.
|
One question and all kinds of test unhappiness @rhatdan . |
|
This definitely needs the updated c/common PR: containers/common#1077 |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
Still a lot of red unhappiness here @rhatdan |
github-actions
bot
added
the
locked - please file new issue/PR
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]