-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4.2.0-rhel] podman: podman rm -f doesn't leave processes #17052
[v4.2.0-rhel] podman: podman rm -f doesn't leave processes #17052
Conversation
check that the container has a valid pid before attempting to use kill($PID, 0) on it. If the PID==0, it means the container is already stopped. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit 494db3e)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
follow-up to 6886e80
when "podman -rm -f" is used on a container in "stopping" state, also
make sure it is terminated before removing it from the local storage.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2155828
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com
(cherry picked from commit 4cf06fe)
Does this PR introduce a user-facing change?