e2e: remove "-it" from podman run & exec #18343
Conversation
openshift-ci
bot
added
release-note-none
approved
Thanks for the heads-up. I think (but am not sure!) that my concern is |
| session.WaitWithDefaultTimeout() | ||
| Expect(session).To(ExitWithError()) | ||
| Expect(session.OutputToString()).To(ContainSubstring("Operation not permitted")) | ||
| Expect(session.ErrorToString()).To(ContainSubstring("Operation not permitted")) |
There was a problem hiding this comment.
For anyone understandably not wanting to glaze their eyes looking at all the diffs: this and line 453 are the only two changes that are not s/"-it", // (or -ti).
...at least as many as possible. "run/exec -it" make no sense in a CI environment; I believe the vast majority of these are the result of fingers typing on autopilot, then copy/pasting cascades from those. This PR gets rid of as many -it/-ti as possible. Some are still needed for testing purposes. Y'all have no idea how much I hate containers#10927 (the "no logs from conmon" flake). This does not fix the underlying problem, nor does it even eliminate the flake (The "exec terminal doesn't hang" test needs to keep the -ti flag, and that's one of the most popular flakers). But this at least reduces the scope of the problem. It also removes a ton of nasty orange "input device is not a TTY" warnings from logs. Signed-off-by: Ed Santiago <santiago@redhat.com>
| Expect(outlines[0]).To(Equal("1")) | ||
| Expect(outlines[1]).To(Equal("2")) |
There was a problem hiding this comment.
Update, Wednesday AM: another change that is not a removal of -i/-t
|
@containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
...at least as many as possible. "run/exec -it" make no sense
in a CI environment; I believe the vast majority of these are
the result of fingers typing on autopilot, then copy/pasting
cascades from those. This PR gets rid of as many -it/-ti as
possible. Some are still needed for testing purposes.
Y'all have no idea how much I hate #10927 (the "no logs from conmon"
flake). This does not fix the underlying problem, nor does it even
eliminate the flake (The "exec terminal doesn't hang" test needs
to keep the -ti flag, and that's one of the most popular flakers).
But this at least reduces the scope of the problem. It also removes
a ton of nasty orange "input device is not a TTY" warnings from logs.
Signed-off-by: Ed Santiago santiago@redhat.com