Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwsh completers ∀x∈ {cmds, aliases} #18847

Closed
wants to merge 1 commit into from

Conversation

mavaddat
Copy link

@mavaddat mavaddat commented Jun 10, 2023

Provide PowerShell argument completer for all podman commands and aliases. This is especially useful for cases where user set docker as an alias.

Also, the PowerShell argument completer will now apply for podman.exe if that is an entrypoint to podman that is set by System.Environment. This is useful for cases (Windows contexts) where the executable has *.exe extension. (We don't want to deny argument completion when the user is employing a canonical name for the executable, which it does in the status quo.)

Does this PR introduce a user-facing change?

Yes.

Extend PowerShell argument completer to apply for each `podman` command (including `*.exe`) and aliases (e.g., `docker`).

Provide arg completer for all `podman` commands and aliases. Useful for case where user set `docker` as an alias.

Signed-off-by: Mavaddat Javid <5055400+mavaddat@users.noreply.github.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mavaddat
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see these files are auto generated with podman completion and this just uses the completion scripts from https://github.com/spf13/cobra. I suggest you propose this change there.

@Luap99 Luap99 closed this Jun 12, 2023
@mavaddat mavaddat deleted the patch-1 branch June 12, 2023 14:27
@mavaddat
Copy link
Author

As you can see these files are auto generated with podman completion and this just uses the completion scripts from https://github.com/spf13/cobra. I suggest you propose this change there.

I did see that note, but I thought it meant that this is the source from which the podman completion is created.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants