Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor in latests containers/common #18953

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

BlackHole1
Copy link
Contributor

To include export HostContainersInternal

Ref:

  1. refactor(hosts): export hostContainersInternal variable common#1516
  2. fix(machine): throw error connection refused after set proxy #18936

Does this PR introduce a user-facing change?

None

/cc @Luap99

To include export HostContainersInternal

Signed-off-by: Black-Hole1 <bh@bugs.cc>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a commit on top that uses HostContainersInternal?

@BlackHole1
Copy link
Contributor Author

Hey @vrothberg 👋. I think the PR should be kept clean. This PR is only responsible for updating the common vendor. After this PR is merged, I will submit another PR to update HostContainersInternal 😀.

@vrothberg
Copy link
Member

Hey @vrothberg wave. I think the PR should be kept clean. This PR is only responsible for updating the common vendor. After this PR is merged, I will submit another PR to update HostContainersInternal grinning.

I leave it up to you. I prefer to combine such changes. Less time to review and less stress on CI.

LGTM

@vrothberg
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlackHole1, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6633a91 into containers:main Jun 21, 2023
@BlackHole1 BlackHole1 deleted the update-vendor branch June 21, 2023 10:24
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants