-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor in latests containers/common #18953
vendor in latests containers/common #18953
Conversation
To include export HostContainersInternal Signed-off-by: Black-Hole1 <bh@bugs.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a commit on top that uses HostContainersInternal?
Hey @vrothberg 👋. I think the PR should be kept clean. This PR is only responsible for updating the |
I leave it up to you. I prefer to combine such changes. Less time to review and less stress on CI. LGTM |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlackHole1, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To include export HostContainersInternal
Ref:
connection refused
after set proxy #18936Does this PR introduce a user-facing change?
/cc @Luap99