Trim whitespace from unit files while parsing

[rhatdan]

Fixes: #18979

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@bachradsusi @vrothberg @ygalblum @alexlarsson PTAL

[vrothberg]

LGTM but note that strings.TrimSpace will also left-trim. We may consider using TrimRight instead.

[rhatdan]

I went back and forth on that.

Should the following be valid:

" RemapUsers: keep-id "

[vrothberg]

Probably worth checking how systemd deals with such cases. I am currently flooded and won't find time until Monday to dig into it.

[bachradsusi]

This PR fixes my issue. Thanks!

[rhatdan]

# cat /etc/systemd/system/test.service
[Unit]
Description=skeeo

[Service]
Delegate=true
Type=exec
KillMode=process
   ExecStart=sleep 100   

[Install]
WantedBy=default.target

This service script works fine in systemd.

[TomSweeneyRedHat]

LGTM
But Catch-22, lint is choking on the trailing whitespace in the test that you're trying to add to test how it is handled....

[ygalblum]

LGTM
@vrothberg are you OK with the decision on which trim method is used?

[vrothberg]

Yes, I am cool with trimming on both sides. But let's also test that left-trimming works. Right now, we test right-trims only.