Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v4.6.0-rc1 #19091

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Bump to v4.6.0-rc1 #19091

merged 2 commits into from
Jul 3, 2023

Conversation

ashley-cui
Copy link
Member

@ashley-cui ashley-cui commented Jul 3, 2023

Woke up in a cold sweat realizing I accidentally bumped to v4.6.0 instead of v4.6.0-rc1, glad I caught it before the I pushed the tag.... This is why I shouldn't rush a release in on a Friday.

Does this PR introduce a user-facing change?

None

Signed-off-by: Ashley Cui <acui@redhat.com>
Signed-off-by: Ashley Cui <acui@redhat.com>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2023
@ashley-cui ashley-cui mentioned this pull request Jul 3, 2023
@ashley-cui
Copy link
Member Author

ashley-cui commented Jul 3, 2023

@containers/podman-maintainers PTAL, probably more on the urgent side. Not sure if this is the right thing to do, but let me know. Tag was never pushed.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Back to bed :)

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,ashley-cui,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member

lsm5 commented Jul 3, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2023
@lsm5
Copy link
Member

lsm5 commented Jul 3, 2023

I guess @ashley-cui 's on PTO. I can push the actual tag and create a pre-release

@openshift-merge-robot openshift-merge-robot merged commit 8090f67 into containers:v4.6 Jul 3, 2023
@mheon
Copy link
Member

mheon commented Jul 3, 2023

@lsm5 Sure, please do

@lsm5
Copy link
Member

lsm5 commented Jul 3, 2023

@ashley-cui ashley-cui deleted the rel460 branch September 28, 2023 22:04
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants