go mod: no longer use 1.18 #19204
Merged
go mod: no longer use 1.18 #19204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.18 is EOL and we should not have to set this since the current versions should generate compatible go.sum files anyway. This is an attempt to fix broken renovate PRs which create a different go.sum and thus do not pass CI checks. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
openshift-ci
bot
added
release-note-none
approved
vrothberg
approved these changes
Jul 12, 2023
|
I wonder if this may be the cause or if this is a bug in renovate. |
|
Actually I think there is something wrong with renovate: containers/common#1555 passed tests so I assumed it worked but if I now run make vendor locally I get a diff which means c/common CI is missing the diff check. Anyway this should be good to merge but I don't think it will fix renovate PRs. |
flouthoc
approved these changes
Jul 12, 2023
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.18 is EOL and we should not have to set this since the current versions should generate compatible go.sum files anyway.
This is an attempt to fix broken renovate PRs which create a different go.sum and thus do not pass CI checks.
Does this PR introduce a user-facing change?