Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --podman-only flag to podman generate kube #19211

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Add --podman-only flag to podman generate kube #19211

merged 1 commit into from
Jul 16, 2023

Conversation

jakecorrenti
Copy link
Member

@jakecorrenti jakecorrenti commented Jul 12, 2023 •
edited
Loading

Adds a --podman-only flag to podman generate kube to allow for podman-only reserved annotations to be included in the generated YAML file. These annotations cannot be used by Kubernetes.

Associated with: #19102

Does this PR introduce a user-facing change?

Adds `--podman-only` flag to `podman generate kube` to allow podman-only reserved annotations to be used in the generated YAML file. These annotations cannot be used by Kubernetes

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Jul 12, 2023
@jakecorrenti jakecorrenti mentioned this pull request Jul 12, 2023
Merged
@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2023

I hate the --add-reserved option name, No idea what it means from looking at the option. From my quick read this adds options to the kube.yaml, that would not be allowed in kubernetes, but Podman will use, correct?

@jakecorrenti
Copy link
Member Author

Correct

@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2023

How about
--podmanonly

@jakecorrenti
Copy link
Member Author

That works for me. I'll also make the docs more descriptive

@jakecorrenti jakecorrenti force-pushed the add-reserved-flag-generate branch from 3c3675b to d26a6c5 Compare July 12, 2023 16:37
@jakecorrenti jakecorrenti changed the title Add --add-reserved flag to podman generate kube Add --podmanonly flag to podman generate kube Jul 12, 2023
@jakecorrenti jakecorrenti force-pushed the add-reserved-flag-generate branch from d26a6c5 to 6ee4a7c Compare July 12, 2023 17:14
@mheon
Copy link
Member

mheon commented Jul 13, 2023

Would --podman-only be acceptable? I don't like mashing words together in options

@mheon
Copy link
Member

mheon commented Jul 13, 2023

Otherwise code LGTM. Swagger is angry though.

@rhatdan
Copy link
Member

rhatdan commented Jul 14, 2023

I am not crazy with options with "-" in them. But we already have --read-only, I guess there is precedent.

@jakecorrenti
Add --podman-only flag to podman generate kube
d0602e8 
Adds an `--podman-only` flag to `podman generate kube` to allow for
reserved annotations to be included in the generated YAML file.

Associated with: containers#19102

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
@jakecorrenti jakecorrenti force-pushed the add-reserved-flag-generate branch from 6ee4a7c to d0602e8 Compare July 14, 2023 13:36
@jakecorrenti jakecorrenti changed the title Add --podmanonly flag to podman generate kube Add --podman-only flag to podman generate kube Jul 14, 2023
@jakecorrenti
Copy link
Member Author

Looks like a flake

@rhatdan
Copy link
Member

rhatdan commented Jul 15, 2023

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakecorrenti, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2023
@jakecorrenti
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit 49a924c into containers:main Jul 16, 2023
@edsantiago edsantiago mentioned this pull request Jul 31, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakecorrenti @rhatdan @mheon @openshift-merge-robot