systests: manifest zstd test: lots of tiny cleanups #19861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily, build test images FROM scratch, not alpine, to avoid image pulls and network flakes and potential pull- the-rug-out errors if the base alpine image changes. This was much more complicated than it should've been, because creating unique arch-specific FROM-scratch images triggered a weird manifest bug, filed as containers#19860. Also: - add a teardown() to clean up manifests - remove test for skopeo (skopeo is required for sys tests) - remove unnecessary intermediate tmpdir - deduplicate, by looping over amd+arm - fix indentation - and, finally, clean up dangling images (this was the initial reason behind my diving in here. Such a simple thing, I thought.) Signed-off-by: Ed Santiago <santiago@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily, build test images FROM scratch, not alpine, to
avoid image pulls and network flakes and potential pull-
the-rug-out errors if the base alpine image changes.
This was much more complicated than it should've been,
because creating unique arch-specific FROM-scratch images
triggered a weird manifest bug, filed as #19860.
Also:
reason behind my diving in here. Such a simple thing, I thought.)
Signed-off-by: Ed Santiago santiago@redhat.com