e2e: more ExitCleanly() on more test files #19959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ongoing steps toward RUN-1907: replace Exit(0) with ExitCleanly() Commit 1 of 2: simple automated string-replace, plus fixes to includes. Signed-off-by: Ed Santiago <santiago@redhat.com>
openshift-ci
bot
added
do-not-merge/release-note-label-needed
Commit 2 of 2: manual fixes to get tests to pass. Mostly adding "-q", but in some cases reverting back to Exit(0) with progress-message checks. Plus, fix a typo in an error message Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
force-pushed
the
e2e_check_stderr__more
branch
from
07b9e34 to
df011f4
Compare
Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
commented
Sep 13, 2023
Comment on lines
+367
to
+369
| showrun make install.tools | ||
| showrun dnf remove -y gvisor-tap-vsock | ||
| showrun dnf install -y podman-docker* |
There was a problem hiding this comment.
@lsm5, @containers/podman-maintainers this was intended to fix the CI breakage, and it did, but I don't know how/if this will work after @lsm5's Obsoletes fix, or on next CI-VM update, or when the moon wanes gibbous.
|
/approve |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel ...in the interests of fixing the CI emergency. Review feedback still appreciated. |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying a different approach. Instead of one-file-at-a-time, do a bunch of test files, but in two commits: one a simple string substitution of
Expect...Exit(0)to...ExitCleanly(), and the second being manual fixes. The second commit is the important one to review.