vendor latest c/common

[Luap99]

Does this PR introduce a user-facing change?

Make podman tag/untag parallel race free (https://github.com/containers/podman/issues/17515)

[vrothberg]

LGTM

Seems like I created #20447 at the very same time (minus the test/apiv2 change) :)

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[flouthoc]

LGTM

[lsm5]

# get https://proxy.golang.org/golang.org/x/sys/@v/v0.0.0-20190916202348-b4ddaad3f8a3.zip: 200 OK (0.193s)
go: github.com/containernetworking/cni@v0.7.1: Get "https://proxy.golang.org/github.com/containernetworking/cni/@v/v0.7.1.mod": EOF
error: Bad exit status from /var/tmp/rpm-tmp.A7z8rl (%build)
    Bad exit status from /var/tmp/rpm-tmp.A7z8rl (%build)

on centos 8 and 9

[vrothberg]

Google's infrastructure in south east US is down ...

[vrothberg]

Restarted in hope the infra is back

[Luap99]

# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
         # #|     FAIL: NOTIFY_SOCKET is passed to container
         # #| expected: 'Pulling image localhost:42759/name:tag inside systemd: setting pull timeout to 5m0s'
         # #|   actual: 'Pulling image //localhost:42759/name:tag inside systemd: setting pull timeout to 5m0s'
         # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@vrothberg Is it expected the the URL starts with //? It feels like the transport name is missing, I would expect at least docker:// because just two slashes make no sense at all. Seems to be caused by containers/common#1704.

[vrothberg]

@vrothberg Is it expected the the URL starts with //?

Yes, that is the "string within transport". Apologies for not making sure it's passing the test. Could you update the test to buy us some time?

[Luap99]

@vrothberg Is it expected the the URL starts with //?

Yes, that is the "string within transport". Apologies for not making sure it's passing the test. Could you update the test to buy us some time?

Yes I am fine with updating the tests the reason I am asking is because the string makes no sense to me. IMO it must either be just localhost... like it is right now or docker://localhost.... Why would it be //localhost? That is wrong as it cannot even be used as syntax for podman pull.

[Luap99]

https://github.com/containers/image/blob/106139461bbcaef60ced9e479afb7553312aaab9/types/types.go#L52-L54

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,flouthoc,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ashley-cui]

/lgtm