Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/container-orchestrated-devices/container-device-interface to v0.6.2 #20558

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Nov 1, 2023

This change replaces #20555 which bumps the github.com/container-orchestrated-devices/container-device-interface to v0.6.2.

The change included a rename of the go module to use a shortened URL as part of a migration to the cncf-tags GitHub organisation.

This also requires:

none

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@elezar
Copy link
Contributor Author

elezar commented Nov 1, 2023

As a note to the reviewers. I'm happy to handle the containers/common update in a separate PR so that this one can focus on the CDI dependency bump.

@elezar
Copy link
Contributor Author

elezar commented Nov 2, 2023

@rhatdan I see that same cross-compilation errors for the containers/common changes are being triggered here as in #20517. I'm happy to create a PR there to address this as well.

@rhatdan
Copy link
Member

rhatdan commented Nov 2, 2023

Thanks.

@github-actions github-actions bot removed the kind/api-change Change to remote API; merits scrutiny label Nov 3, 2023
@elezar
Copy link
Contributor Author

elezar commented Nov 3, 2023

I see that @giuseppe beat me to it with containers/common#1726. Updated after rebase.

This updates the container-device-interface dependency to v0.6.2 and renames the import to
tags.cncf.io/container-device-interface to make use of the new vanity URL.

[NO NEW TESTS NEEDED]

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@rhatdan
Copy link
Member

rhatdan commented Nov 4, 2023

LGTM
/approve
@giuseppe @mheon @vrothberg @Luap99 PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2023
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elezar, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit f845e1a into containers:main Nov 6, 2023
93 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants