utils: close a couple of ReadClosers #20823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils.Tar() and utils.TarWithChroot() both return ReadClosers, but when we called them from utils.TarToFilesystem() and utils.TarChrootToFilesystem() respectively, they were not being closed. [NO NEW TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
How did you find these? |
|
/lgtm |
|
I had started looking at places that call the archive package's Tar() function to archive the contents of directories during a discussion in a storage PR. This happened to be the first one, and having forgotten to Close() ReadClosers plenty of times myself, I guess I'm a little sensitive to it. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.Tar()andutils.TarWithChroot()both returnReadClosers, but when we called them fromutils.TarToFilesystem()andutils.TarChrootToFilesystem()respectively, they were not being closed.Does this PR introduce a user-facing change?