-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppleHV: update LastUp time #21246
AppleHV: update LastUp time #21246
Conversation
LastUp now correctly reports the lastUp time for podman machine on AppleHV, for both inspect and list. [NO NEW TESTS NEEDED] since this fixes an existing failing test. Signed-off-by: Ashley Cui <acui@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cockpit tests failed for commit f374e07. @martinpitt, @jelly, @mvollmer please check. |
LGTM will give this a test on my machine later, but that isn't a blocker |
/lgtm |
1783142
into
containers:main
/cherry-pick v4.9 |
@mheon: #21246 failed to apply on top of branch "v4.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like it will need a manual backport |
LastUp now correctly reports the lastUp time for podman machine on AppleHV, for both inspect and list.
[NO NEW TESTS NEEDED]
since this fixes an existing failing test.
Does this PR introduce a user-facing change?
Fixes: #21244
Related: #21245