Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up podman machine remote user correctly #21266

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Set up podman machine remote user correctly #21266

merged 1 commit into from
Jan 17, 2024

Conversation

baude
Copy link
Member

@baude baude commented Jan 16, 2024

The remote user functionality was not quite correct. This PR breaks out the accumulation of user descriptions into a separate function. One odditiy is ignition must be told to NOT create the core user (or it will by default) by "adding" the core user with a set bool.

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

mheon
mheon reviewed Jan 16, 2024
View reviewed changes
pkg/machine/qemu/machine.go Outdated Show resolved Hide resolved
@mheon
Copy link
Member

mheon commented Jan 16, 2024

One nit otherwise LGTM

@jakecorrenti
Copy link
Member

code LGTM. Mac failures aren't a timeout but check if running while starting isn't tracked here #21245. Not sure if it needs to be taken care of in this PR or if it need to be added to the list of tests to be fixed.

gbraad
gbraad approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although debug seems 'random' without context/remark.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Set up podman machine remote user correctly
1964dbd 
The remote user functionality was not quite correct.  This PR breaks out
the accumulation of user descriptions into a separate function.  One
odditiy is ignition must be told to NOT create the core user (or it will
by default) by "adding" the core user with a set bool.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
@baude
Copy link
Member Author

baude commented Jan 17, 2024

fixed up, whoever merges this, please attempt a cherry-pick for 4.9 as well.

@mheon ^^

@mheon
Copy link
Member

mheon commented Jan 17, 2024

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@mheon
Copy link
Member

mheon commented Jan 17, 2024

/cherry-pick v4.9

@openshift-cherrypick-robot
Copy link
Collaborator

@mheon: once the present PR merges, I will cherry-pick it on top of v4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick v4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@baude
Copy link
Member Author

baude commented Jan 17, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6c5eeaa into containers:main Jan 17, 2024
91 of 92 checks passed
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2024
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@mheon: new pull request created: #21280

In response to this:

/cherry-pick v4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

@gbraad gbraad gbraad approved these changes

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baude @mheon @jakecorrenti @openshift-cherrypick-robot @gbraad