rootless: copy some settings from the global configuration #2222
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
Code LGTM |
| } | ||
|
|
||
| // Cherry pick the settings we want from the global configuration | ||
| runtime.config.ConmonPath = tmpConfig.ConmonPath |
There was a problem hiding this comment.
Shouldn't we make sure these are not set, and only set them.
If I set the ConmonPath in my local config isn't this an issue.
There was a problem hiding this comment.
We are in this code branch only when ~/.config/containers/libpod.conf doesn't exist.
The only place where we could set them is from the default configuration we create.
|
let's wait for @sysrich before merging this |
giuseppe
force-pushed
the
rootless-copy-paths-global-conf
branch
from
7d6b3d9
to
552e15d
Compare
|
/retest |
if some paths are overriden in the global configuration file, be sure that rootless podman honors them. Closes: containers#2174 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
rootless-copy-paths-global-conf
branch
from
552e15d
to
61979d8
Compare
|
rebased, tests are green now |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
if some paths are overriden in the global configuration file, be sure
that rootless podman honors them.
Closes: #2174
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com