Windows: clean up temporary perl install #22248
Conversation
openshift-ci
bot
added
release-note-none
approved
contrib/cirrus/win-lib.ps1
Outdated
| Write-Host "Invoking Logformatter" | ||
| Set-Item "Env:PATH" "$Env:PATH;C:\Strawberry\perl\bin" |
There was a problem hiding this comment.
Not a blocker if that's required for perl to work. But adding it to the PATH should be part of the installation.
There was a problem hiding this comment.
The case-insensitive expression env.path does not appear anywhere in the automation_images repo (with one false positive). This suggests that all the other things that get installed by automation_images:
retryInstall git archiver psexec golang mingw
...are automatically installed into a proper place where they are visible in the caller's PATH. Do you know why Strawberry Perl is different? Or, taking a step back, is it possible that this Set-Item is not even necessary? Should I resubmit the PR and see if it works?
There was a problem hiding this comment.
As for the rest of the packages installed via chocolatey it should not be needed (the installer does that for us). But that's depends on the installer implementation.
I had to add it in my PR to be able to run the installer and then run perl from the same shell session. Now perl is installed at build time so the CI spawns a shell session where perl should already be in PATH.
I would try to resubmit the PR to see if it works yes.
Followup to containers#21991. Strawberry Perl is now installed by default in CI VMs[1], so we no longer need the temporary install-perl code. [1] containers/automation_images#337 Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
force-pushed
the
windows-perl-is-in-vms
branch
from
f751c76 to
ff133a5
Compare
|
Confirmation: wsl-windows log. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Followup to #21991. Strawberry Perl is now installed by default
in CI VMs[1], so we no longer need the temporary install-perl code.
[1] containers/automation_images#337
Signed-off-by: Ed Santiago santiago@redhat.com